Add @scope decorator
#1998
Merged
Add @scope decorator
#1998
+268
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
lib:tcgc
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
live1206
requested review from
lmazuel,
m-nash,
iscai-msft,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
tadelesh
reviewed
Jan 3, 2025
tadelesh
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #964
The scope parameter of
@scopedecorator is not working as the normal decorator.For a normal decorator, we need to get the decorator value from state map based on the scope and the current emitter name. If the value hit from the state map with current emitter name, it's a positive case, if not hit, it's a negative case.
With the normal decorator scope handling, if the decorator is absent it is a negative case. For the case below, we don't need to handle
@clientnamedecorator, it is a negative case.But for
@scopedecorator, when it is absent, it meansAllScopes, which is also a positive case. For below two cases, python emitter should include this operation, both of them are positive case.and
For incremental applying, the mechanism should be similar to the normal decorator scope handling.